View Single Post

   
  #4 (permalink)  
Old 04-15-2008, 11:33 PM
Martijn van Oosterhout
 
Posts: n/a
Default Re: psql -f doesn't complain about directories

On Wed, Nov 14, 2007 at 05:15:20PM -0300, Alvaro Herrera wrote:
> > Should we do some kind of stat() before opening the file and abort if it's a
> > directory?

>
> Actually anything other than a plain file, right? (Do we really want to
> be able to psql -f a_pipe?)


Sure, why not. To be honest I think that psql shouldn't be ignoring the
EISDIR error the kernel is returning.

Have a nice day,
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/
> Those who make peaceful revolution impossible will make violent revolution inevitable.
> -- John F Kennedy


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFHO1hdIB7bNG8LQkwRAmvHAKCBuRblr2cj4gP5mURmgv W7SzbdIgCeOzSV
zA2KmSf8nkkGwvSSrfzM+L0=
=zeV7
-----END PGP SIGNATURE-----

Reply With Quote