View Single Post

   
  #8 (permalink)  
Old 04-16-2008, 02:40 AM
Ludek Finstrle
 
Posts: n/a
Default Re: More strict bind param count checking

> Looks pretty good to me.

Very good.

> It's more safe to adjust the param_count in case of apdopts->allocated <
> param_count.


Thanks fot pointing it.

> Also it's safe to change the following code in PGAPI_ParamData.
>
> /* At least 1 data at execution parameter, so Fill in the token value */
> for (; i < apdopts->allocated; i++)


I implement it both. New patch attached.
I also change older test for param number from == to >= and
comment out some not used code.

Thank you very much again Hiroshi

Luf

P.S. Dave can I commit it if there it no negative answer?


---------------------------(end of broadcast)---------------------------
TIP 4: Have you searched our list archives?

http://archives.postgresql.org

Reply With Quote