View Single Post

   
  #11 (permalink)  
Old 04-19-2008, 07:28 AM
Tom Lane
 
Posts: n/a
Default Re: Fix for win32 stat() problems

Magnus Hagander <magnus@hagander.net> writes:
> A whole lot simpler patch :-)


Seems like you no longer need the !defined(_DIRMOD_C) bit here?
Also please include a comment about why <sys/stat.h> has to be
forcibly included.

A more general question: can't we get rid of most of the #ifdef WIN32
cruft in include/port.h, and put it in include/port/win32.h instead?
Seems cleaner that way, at least for things where there's just an
#ifdef WIN32 hunk and not two cases for Win and not-Win.

regards, tom lane

--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches

Reply With Quote