Unix Technical Forum

rl(4) NIC driver and Alpha's, PR 3795

This is a discussion on rl(4) NIC driver and Alpha's, PR 3795 within the mailing.openbsd.tech forums, part of the OpenBSD category; --> The following patch from PR 3795 fixes 2 issues with unaligned memory access on the alpha archietcture which would ...


Go Back   Unix Technical Forum > Unix Operating Systems > OpenBSD > mailing.openbsd.tech

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 02-18-2008, 08:19 AM
Brad
 
Posts: n/a
Default rl(4) NIC driver and Alpha's, PR 3795

The following patch from PR 3795 fixes 2 issues with unaligned memory
access on the alpha archietcture which would result in kernel panics.

If you have an rl(4) or two and could please try this out on your
alpha system, especially if you have been noticing panics, that would
be great. I don't forrsee any breakage on i386 systems but just to be
sure please take it for a test run on some i386 systems too.

BTW, you can use either 3.6 or -current to test this out.

// Brad

Index: sys/dev/ic/rtl81x9.c
================================================== =================
RCS file: /cvs/src/sys/dev/ic/rtl81x9.c,v
retrieving revision 1.27
diff -u -p -r1.27 rtl81x9.c
--- sys/dev/ic/rtl81x9.c 23 Sep 2004 17:45:16 -0000 1.27
+++ sys/dev/ic/rtl81x9.c 27 Sep 2004 19:40:50 -0000
@@ -667,12 +667,13 @@ rl_rxeof(sc)
if (m == NULL)
ifp->if_ierrors++;
else {
- m_adj(m, ETHER_ALIGN);
m_copyback(m, wrap, total_len - wrap,
sc->rl_cdata.rl_rx_buf);
m = m_pullup(m, sizeof(struct ether_header));
if (m == NULL)
ifp->if_ierrors++;
+ else
+ m_adj(m, ETHER_ALIGN);
}
cur_rx = (total_len - wrap + ETHER_CRC_LEN);
} else {
@@ -1154,7 +1155,8 @@ void rl_stop(sc)
if (sc->rl_cdata.rl_tx_chain[i] != NULL) {
m_freem(sc->rl_cdata.rl_tx_chain[i]);
sc->rl_cdata.rl_tx_chain[i] = NULL;
- CSR_WRITE_4(sc, RL_TXADDR0 + i, 0x00000000);
+ CSR_WRITE_4(sc, RL_TXADDR0 + (i * sizeof(u_int32_t)),
+ 0x00000000);
}
}

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 09:29 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Search Engine Optimization by vBSEO 3.2.0
www.UnixAdminTalk.com