Unix Technical Forum

minor windows & cygwin regression failures on stable branch

This is a discussion on minor windows & cygwin regression failures on stable branch within the pgsql Hackers forums, part of the PostgreSQL category; --> I have seen some small regression failures on REL8_0_STABLE - I thought as we're coming up to a release ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-11-2008, 04:13 AM
Andrew Dunstan
 
Posts: n/a
Default minor windows & cygwin regression failures on stable branch


I have seen some small regression failures on REL8_0_STABLE - I thought
as we're coming up to a release I'd better run the stable branch through
on my buildfarm clients.

Windows has ordering failures on the join and rules tests - Cygwin has a
failures on the stats test. See buildfarm for details.

Does anyone know why these might have happened? Both these platforms had
no errors on this branch 3 weeks ago.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-11-2008, 04:13 AM
Tom Lane
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable branch

Andrew Dunstan <andrew@dunslane.net> writes:
> Windows has ordering failures on the join and rules tests - Cygwin has a
> failures on the stats test. See buildfarm for details.


The ordering failures seem to be because the recent planner hacking has
taken us back to preferring merge joins for these tests, and Windows'
version of qsort has bizarre behavior for equal keys.

I put an ORDER BY in the rules test. For join, I'm inclined to think
that the best bet is to resurrect the join_1.out variant comparison
file that we had awhile ago. Unfortunately, what's in the CVS archives
is out of date and can't be used directly. Could you send me the actual
rules.out you get on Windows to use for a comparison file?

Dunno about the stats failure. It looks like the stats collector just
isn't working on Cygwin, but AFAIR no one has touched that code lately.

Do these machines fail on HEAD too? (There don't seem to be any active
Windows buildfarm machines for HEAD, which is surely ungood. Won't
someone step up and put one into the regular rotation?)

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-11-2008, 04:14 AM
Andrew Dunstan
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable



Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>Windows has ordering failures on the join and rules tests - Cygwin has a
>>failures on the stats test. See buildfarm for details.
>>
>>

>
>The ordering failures seem to be because the recent planner hacking has
>taken us back to preferring merge joins for these tests, and Windows'
>version of qsort has bizarre behavior for equal keys.
>
>I put an ORDER BY in the rules test. For join, I'm inclined to think
>that the best bet is to resurrect the join_1.out variant comparison
>file that we had awhile ago. Unfortunately, what's in the CVS archives
>is out of date and can't be used directly. Could you send me the actual
>rules.out you get on Windows to use for a comparison file?
>
>


join.out sent off list

>Dunno about the stats failure. It looks like the stats collector just
>isn't working on Cygwin, but AFAIR no one has touched that code lately.
>
>


It's worked before, that's the strange thing. I'll check some more.

>Do these machines fail on HEAD too? (There don't seem to be any active
>Windows buildfarm machines for HEAD, which is surely ungood. Won't
>someone step up and put one into the regular rotation?)
>
>
>
>


Sufficient unto the day is the evil thereof (appropriate quotation for
Good friday). I will address HEAD in due course.

The buildfarm members for both of these are in reality my laptop, which
doesn't even run Windows all the time, and has lots of other duties
anyway. We (or rather Josh Berkus and Bruce, at my request) are looking
for a replacement.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-11-2008, 04:14 AM
Andrew Dunstan
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable



Tom Lane wrote:

>Dunno about the stats failure. It looks like the stats collector just
>isn't working on Cygwin, but AFAIR no one has touched that code lately.
>
>


Well, it seems at least to be running. When I fire up postmaster there
are 4 processes running and no indication of failure that I could see on
the log. (There is a complaint about failing to dup(0) after 3195
successes - I assume that has nothing to do with it?)

The good news is that the regression result fixes made Windows native
green again.

cheers

andrew



---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-11-2008, 04:14 AM
Jim Buttafuoco
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable

Andrew,

I can set one up a dedicated windows XP system on monday. I also have some w2k systems that can be used.Are there
directions anywhere?

Jim


---------- Original Message -----------
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Sent: Fri, 25 Mar 2005 22:19:25 -0500
Subject: Re: [HACKERS] minor windows & cygwin regression failures on stable

> Tom Lane wrote:
>
> >Andrew Dunstan <andrew@dunslane.net> writes:
> >
> >
> >>Windows has ordering failures on the join and rules tests - Cygwin has a
> >>failures on the stats test. See buildfarm for details.
> >>
> >>

> >
> >The ordering failures seem to be because the recent planner hacking has
> >taken us back to preferring merge joins for these tests, and Windows'
> >version of qsort has bizarre behavior for equal keys.
> >
> >I put an ORDER BY in the rules test. For join, I'm inclined to think
> >that the best bet is to resurrect the join_1.out variant comparison
> >file that we had awhile ago. Unfortunately, what's in the CVS archives
> >is out of date and can't be used directly. Could you send me the actual
> >rules.out you get on Windows to use for a comparison file?
> >
> >

>
> join.out sent off list
>
> >Dunno about the stats failure. It looks like the stats collector just
> >isn't working on Cygwin, but AFAIR no one has touched that code lately.
> >
> >

>
> It's worked before, that's the strange thing. I'll check some more.
>
> >Do these machines fail on HEAD too? (There don't seem to be any active
> >Windows buildfarm machines for HEAD, which is surely ungood. Won't
> >someone step up and put one into the regular rotation?)
> >
> >
> >
> >

>
> Sufficient unto the day is the evil thereof (appropriate quotation for
> Good friday). I will address HEAD in due course.
>
> The buildfarm members for both of these are in reality my laptop, which
> doesn't even run Windows all the time, and has lots of other duties
> anyway. We (or rather Josh Berkus and Bruce, at my request) are looking
> for a replacement.
>
> cheers
>
> andrew
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

------- End of Original Message -------


---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-11-2008, 04:14 AM
Andrew Dunstan
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable


Jim,

that is just execllent! Thank you so much! I assume you mean XP-Pro - I
gather that user permissions get in the way on XP-HE.

We can make the one machine do double duty for Windows and Cygwin.

You will need installed:
. cygwin, including whatever it takes to build cygwin postgres
. native perl (ActiveState perl works just fine)
. normal native windows postgres build environment (MSys, Mingw,
MSysDTK etc).

After that we'll explore a bit what it takes to automate the buildfarm
processes on Windows. You and I can do that offline.

Let's get this going first and then look at W2K.

cheers

andrew



Jim Buttafuoco wrote:

>Andrew,
>
>I can set one up a dedicated windows XP system on monday. I also have some w2k systems that can be used.Are there
>directions anywhere?
>
>Jim
>
>
>---------- Original Message -----------
>From: Andrew Dunstan <andrew@dunslane.net>
>To: Tom Lane <tgl@sss.pgh.pa.us>
>Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
>Sent: Fri, 25 Mar 2005 22:19:25 -0500
>Subject: Re: [HACKERS] minor windows & cygwin regression failures on stable
>
>
>
>>Tom Lane wrote:
>>
>>
>>
>>>Andrew Dunstan <andrew@dunslane.net> writes:
>>>
>>>
>>>
>>>
>>>>Windows has ordering failures on the join and rules tests - Cygwin has a
>>>>failures on the stats test. See buildfarm for details.
>>>>
>>>>
>>>>
>>>>
>>>The ordering failures seem to be because the recent planner hacking has
>>>taken us back to preferring merge joins for these tests, and Windows'
>>>version of qsort has bizarre behavior for equal keys.
>>>
>>>I put an ORDER BY in the rules test. For join, I'm inclined to think
>>>that the best bet is to resurrect the join_1.out variant comparison
>>>file that we had awhile ago. Unfortunately, what's in the CVS archives
>>>is out of date and can't be used directly. Could you send me the actual
>>>rules.out you get on Windows to use for a comparison file?
>>>
>>>
>>>
>>>

>>join.out sent off list
>>
>>
>>
>>>Dunno about the stats failure. It looks like the stats collector just
>>>isn't working on Cygwin, but AFAIR no one has touched that code lately.
>>>
>>>
>>>
>>>

>>It's worked before, that's the strange thing. I'll check some more.
>>
>>
>>
>>>Do these machines fail on HEAD too? (There don't seem to be any active
>>>Windows buildfarm machines for HEAD, which is surely ungood. Won't
>>>someone step up and put one into the regular rotation?)
>>>
>>>
>>>
>>>
>>>
>>>

>>Sufficient unto the day is the evil thereof (appropriate quotation for
>>Good friday). I will address HEAD in due course.
>>
>>The buildfarm members for both of these are in reality my laptop, which
>>doesn't even run Windows all the time, and has lots of other duties
>>anyway. We (or rather Josh Berkus and Bruce, at my request) are looking
>>for a replacement.
>>
>>cheers
>>
>>andrew
>>
>>---------------------------(end of broadcast)---------------------------
>>TIP 5: Have you checked our extensive FAQ?
>>
>> http://www.postgresql.org/docs/faq
>>
>>

>------- End of Original Message -------
>
>
>---------------------------(end of broadcast)---------------------------
>TIP 8: explain analyze is your friend
>
>
>


---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-11-2008, 04:14 AM
Tom Lane
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable branch

Andrew Dunstan <andrew@dunslane.net> writes:
> Well, it seems at least to be running. When I fire up postmaster there
> are 4 processes running and no indication of failure that I could see on
> the log. (There is a complaint about failing to dup(0) after 3195
> successes - I assume that has nothing to do with it?)


No, that's some code that's trying to measure the number of files we are
allowed to open. It expects to fail, it just thought the particular
errno it got was odd enough to report. Might be worth an #ifdef to tell
it that that errno is expected on Cygwin?

As far as the test failure, maybe we are just not allowing enough time
for the stats collector to run? The thing sits there for 2 sec, which
theoretically is plenty, but it's a busy-wait loop and if the Cygwin
scheduler is not aggressive about taking away timeslices then maybe
the stats processes don't get to run. Try doing the test script by
hand, with just a manual delay instead of the sleep function, and see
if it passes.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-11-2008, 04:15 AM
Andrew Dunstan
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable



Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>Well, it seems at least to be running. When I fire up postmaster there
>>are 4 processes running and no indication of failure that I could see on
>>the log. (There is a complaint about failing to dup(0) after 3195
>>successes - I assume that has nothing to do with it?)
>>
>>

>
>No, that's some code that's trying to measure the number of files we are
>allowed to open. It expects to fail, it just thought the particular
>errno it got was odd enough to report. Might be worth an #ifdef to tell
>it that that errno is expected on Cygwin?
>
>


Yes, looks like the error is EBADF.

>As far as the test failure, maybe we are just not allowing enough time
>for the stats collector to run? The thing sits there for 2 sec, which
>theoretically is plenty, but it's a busy-wait loop and if the Cygwin
>scheduler is not aggressive about taking away timeslices then maybe
>the stats processes don't get to run. Try doing the test script by
>hand, with just a manual delay instead of the sleep function, and see
>if it passes.
>
>
>
>


Yes, when I do that it works. But even when I increase the interval to
30 secs the regression script fails. I tried to use a sleep function
that didn't do a busy-wait loop, but plperl seems to segfault on this
platform :-( What fun.

What has changed in the last 3 weeks is that I refreshed my Cygwin
installation, I think when I was wrestling with the NLS thing. If
nothing in postgres has changed in this area I assume that platform
changes account for the regression.

cheers

andrew.

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #9 (permalink)  
Old 04-11-2008, 04:15 AM
Tom Lane
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable branch

Andrew Dunstan <andrew@dunslane.net> writes:
> What has changed in the last 3 weeks is that I refreshed my Cygwin
> installation, I think when I was wrestling with the NLS thing. If
> nothing in postgres has changed in this area I assume that platform
> changes account for the regression.


Sounds that way to me too, but it's disturbing. One would say they
broke their scheduler :-(. Possibly you should try to stir up some
interest among the Cygwin hackers in looking into this.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #10 (permalink)  
Old 04-11-2008, 04:15 AM
Andrew Dunstan
 
Posts: n/a
Default Re: minor windows & cygwin regression failures on stable



Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>What has changed in the last 3 weeks is that I refreshed my Cygwin
>>installation, I think when I was wrestling with the NLS thing. If
>>nothing in postgres has changed in this area I assume that platform
>>changes account for the regression.
>>
>>

>
>Sounds that way to me too, but it's disturbing. One would say they
>broke their scheduler :-(. Possibly you should try to stir up some
>interest among the Cygwin hackers in looking into this.
>
>
>
>


I'd like somebody else to report the same phenomenon first. Reini?

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 04:53 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Search Engine Optimization by vBSEO 3.2.0
www.UnixAdminTalk.com