Bruce,

> If everyone else is OK with having it fail, that is fine with me, but I
> wanted to make sure folks saw this was happening. Â*I basically saw no
> discussion that we were disabling that syntax. Â*[CC moved to hackers.]

I believe we hashed this out when we added add_missing_from back in 7.3.

In any case, yes, making that kind of query fail is intentional. So it should
go in the release notes as a warning. Suggested text:

====================
add_missing_from now defaults to "true". This means that queries such as the
following:
SELECT pg_class.*;
DELETE FROM table_1 WHERE table_2.fk = table_1.key AND table_2.col3 = TRUE;
.... will no fail with default settings. Either set add_missing_from to TRUE
to re-enable them, or modify your application to support the correct syntax,
such as the new DELETE FROM ... USING (see below).
====================

--
Josh Berkus
Aglio Database Solutions
San Francisco

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Just to prevent a copy/paste error, I'd correct "will no fail" to "will
now fail" in the suggested text below...

-tfo

--
Thomas F. O'Connell
Co-Founder, Information Architect
Sitening, LLC

Strategic Open Source: Open Your i™

http://www.sitening.com/
110 30th Avenue North, Suite 6
Nashville, TN 37203-6320
615-260-0005

On Apr 10, 2005, at 5:49 PM, Josh Berkus wrote:

> Bruce,
>
>> If everyone else is OK with having it fail, that is fine with me, but
>> I
>> wanted to make sure folks saw this was happening. *I basically saw no
>> discussion that we were disabling that syntax. *[CC moved to hackers.]
>
> I believe we hashed this out when we added add_missing_from back in
> 7.3.
>
> In any case, yes, making that kind of query fail is intentional. So
> it should
> go in the release notes as a warning. Suggested text:
>
> ====================
> add_missing_from now defaults to "true". This means that queries such
> as the
> following:
> SELECT pg_class.*;
> DELETE FROM table_1 WHERE table_2.fk = table_1.key AND table_2.col3 =
> TRUE;
> ... will no fail with default settings. Either set add_missing_from
> to TRUE
> to re-enable them, or modify your application to support the correct
> syntax,
> such as the new DELETE FROM ... USING (see below).
> ====================
>
> --
> Josh Berkus
> Aglio Database Solutions
> San Francisco

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly