Unix Technical Forum

latest pgcrypto patches cause compile errors

This is a discussion on latest pgcrypto patches cause compile errors within the pgsql Hackers forums, part of the PostgreSQL category; --> looks like the latest pgcrypto-patches that just got applied cause widespread failures on the buildfarm machines: http://www.pgbuildfarm.org/cgi-bin/show_status.pl Stefan ---------------------------(end ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > pgsql Hackers

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-11-2008, 05:48 AM
Stefan Kaltenbrunner
 
Posts: n/a
Default latest pgcrypto patches cause compile errors

looks like the latest pgcrypto-patches that just got applied cause
widespread failures on the buildfarm machines:

http://www.pgbuildfarm.org/cgi-bin/show_status.pl



Stefan

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #2 (permalink)  
Old 04-11-2008, 05:48 AM
Marko Kreen
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:
> looks like the latest pgcrypto-patches that just got applied cause
> widespread failures on the buildfarm machines:
>
> http://www.pgbuildfarm.org/cgi-bin/show_status.pl


Seems like Bruce forgot to 'cvs add' new files...

--
marko


---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #3 (permalink)  
Old 04-11-2008, 05:48 AM
Bruce Momjian
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors

Marko Kreen wrote:
> On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:
> > looks like the latest pgcrypto-patches that just got applied cause
> > widespread failures on the buildfarm machines:
> >
> > http://www.pgbuildfarm.org/cgi-bin/show_status.pl

>
> Seems like Bruce forgot to 'cvs add' new files...


All new files added, and I think all the pgcrypto patches are now
applied to CVS. I just added the openssl version patch, I see the
IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
already in.

Is there anything else outstanding for pgcrypto?

--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #4 (permalink)  
Old 04-11-2008, 05:48 AM
Marko Kreen
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote:
> All new files added, and I think all the pgcrypto patches are now
> applied to CVS. I just added the openssl version patch, I see the
> IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
> already in.
>
> Is there anything else outstanding for pgcrypto?


No, we are fully synched now.

That leaves only 2 things in my TODO list for 8.1:

- New documentation.
- I've spotted a few buggy comments in new code. Fix them.

--
marko


---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #5 (permalink)  
Old 04-11-2008, 05:48 AM
Marko Kreen
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote:
> Marko Kreen wrote:
> > On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:
> > > looks like the latest pgcrypto-patches that just got applied cause
> > > widespread failures on the buildfarm machines:
> > >
> > > http://www.pgbuildfarm.org/cgi-bin/show_status.pl

> >
> > Seems like Bruce forgot to 'cvs add' new files...

>
> All new files added, and I think all the pgcrypto patches are now
> applied to CVS. I just added the openssl version patch, I see the
> IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
> already in.
>
> Is there anything else outstanding for pgcrypto?


I see from buildfarm, that pgcrypto fails to build on a
non-OpenSSL machine. The reason for it is a stale openssl/bn.h
include in pgp-pubdec.c. I did not spot it, as even for
--without-openssl build I still had OpenSSL intalled.

--
marko



---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #6 (permalink)  
Old 04-11-2008, 05:48 AM
Bruce Momjian
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors

Marko Kreen wrote:
> On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote:
> > Marko Kreen wrote:
> > > On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote:
> > > > looks like the latest pgcrypto-patches that just got applied cause
> > > > widespread failures on the buildfarm machines:
> > > >
> > > > http://www.pgbuildfarm.org/cgi-bin/show_status.pl
> > >
> > > Seems like Bruce forgot to 'cvs add' new files...

> >
> > All new files added, and I think all the pgcrypto patches are now
> > applied to CVS. I just added the openssl version patch, I see the
> > IMMUTABLE patch is already in, and I see the autoconfiguration stuff is
> > already in.
> >
> > Is there anything else outstanding for pgcrypto?

>
> I see from buildfarm, that pgcrypto fails to build on a
> non-OpenSSL machine. The reason for it is a stale openssl/bn.h
> include in pgp-pubdec.c. I did not spot it, as even for
> --without-openssl build I still had OpenSSL intalled.


Removed from CVS.

--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #7 (permalink)  
Old 04-11-2008, 05:48 AM
Marko Kreen
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote:
> Marko Kreen wrote:
> > I see from buildfarm, that pgcrypto fails to build on a
> > non-OpenSSL machine. The reason for it is a stale openssl/bn.h
> > include in pgp-pubdec.c. I did not spot it, as even for
> > --without-openssl build I still had OpenSSL intalled.

>
> Removed from CVS.


One more failure:

http://www.pgbuildfarm.org/cgi-bin/s...-10%2017:39:18

I think this is because we don't have -lz in SHLIB_LINK.
Following patch fixes it.

--
marko


---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #8 (permalink)  
Old 04-11-2008, 05:48 AM
Marko Kreen
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors

On Sun, Jul 10, 2005 at 09:10:29PM +0300, Marko Kreen wrote:
> On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote:
> > Marko Kreen wrote:
> > > I see from buildfarm, that pgcrypto fails to build on a
> > > non-OpenSSL machine. The reason for it is a stale openssl/bn.h
> > > include in pgp-pubdec.c. I did not spot it, as even for
> > > --without-openssl build I still had OpenSSL intalled.

> >
> > Removed from CVS.

>
> One more failure:
>
> http://www.pgbuildfarm.org/cgi-bin/s...-10%2017:39:18
>
> I think this is because we don't have -lz in SHLIB_LINK.
> Following patch fixes it.


Here's the patch.

--
marko



---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
  #9 (permalink)  
Old 04-11-2008, 05:48 AM
Bruce Momjian
 
Posts: n/a
Default Re: latest pgcrypto patches cause compile errors


Patch applied. Thanks.

---------------------------------------------------------------------------


Marko Kreen wrote:
> On Sun, Jul 10, 2005 at 09:10:29PM +0300, Marko Kreen wrote:
> > On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote:
> > > Marko Kreen wrote:
> > > > I see from buildfarm, that pgcrypto fails to build on a
> > > > non-OpenSSL machine. The reason for it is a stale openssl/bn.h
> > > > include in pgp-pubdec.c. I did not spot it, as even for
> > > > --without-openssl build I still had OpenSSL intalled.
> > >
> > > Removed from CVS.

> >
> > One more failure:
> >
> > http://www.pgbuildfarm.org/cgi-bin/s...-10%2017:39:18
> >
> > I think this is because we don't have -lz in SHLIB_LINK.
> > Following patch fixes it.

>
> Here's the patch.
>
> --
> marko
>


[ Attachment, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
choose an index scan if your joining column's datatypes do not
match

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 09:40 AM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Search Engine Optimization by vBSEO 3.2.0
www.UnixAdminTalk.com