A fix and a new functionnality for the colour patch
This is a discussion on A fix and a new functionnality for the colour patch within the pgsql Interfaces Pgadmin Hackers forums, part of the PostgreSQL category; --> Hi, The colour patch commited by Dave during pgCon2008 allows a user to add a background color to the ...
| |||||||
| FAQ | Members List | Calendar | Search | Today's Posts | Mark Forums Read |
06-14-2008, 04:58 PM
| ||||
| ||||
 A fix and a new functionnality for the colour patch Hi, The colour patch commited by Dave during pgCon2008 allows a user to add a background color to the treeview for each specific registered server. When a user deletes the colour in the server's property, pgAdmin will use a black (#000000) background. The treeview node's text will be unreadable. What the patch does is impliying white colour when the user doesn't spécify a colour. The new functionality adds a colour button that opens the standard colour dialog. The user doesn't new to know the HTML colour coding. Comments? Regards. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers      |
|
06-17-2008, 04:03 AM
| |||
| |||
| Re: A fix and a new functionnality for the colour patch On Sat, Jun 14, 2008 at 4:21 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Hi, > > The colour patch commited by Dave during pgCon2008 allows a user to add a > background color to the treeview for each specific registered server. > > When a user deletes the colour in the server's property, pgAdmin will usea > black (#000000) background. The treeview node's text will be unreadable. > What the patch does is impliying white colour when the user doesn't spécify > a colour. Hmm, thought I covered that cased. Thanks for catching. > The new functionality adds a colour button that opens the standard colour > dialog. The user doesn't new to know the HTML colour coding. Is the colour dialog available on all platforms? I did look for one when writing the original patch but couldn't find it. It's possible I was hungover from the Jagermeister the night before though (EDB party at pgCon :-) ). > Comments? You spelt colour wrong :-). Other than that (and the possible issue above), looks good. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
06-17-2008, 04:03 AM
| |||
| |||
| Re: A fix and a new functionnality for the colourpatch Dave Page a écrit : > On Sat, Jun 14, 2008 at 4:21 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Hi, >> >> The colour patch commited by Dave during pgCon2008 allows a user to add a >> background color to the treeview for each specific registered server. >> >> When a user deletes the colour in the server's property, pgAdmin will use a >> black (#000000) background. The treeview node's text will be unreadable. >> What the patch does is impliying white colour when the user doesn't spécify >> a colour. > > Hmm, thought I covered that cased. Thanks for catching. > At least, it didn't work on GTK+. >> The new functionality adds a colour button that opens the standard colour >> dialog. The user doesn't new to know the HTML colour coding. > > Is the colour dialog available on all platforms? AFAIK, yes, it does. According to the manual (http://docs.wxwidgets.org/2.8.6/wx_c...overview.html), "Some dialogs have both platform-dependent and platform-independent implementations, so that if underlying windowing systems do not provide the required functionality, the generic classes and functions can stand in." > I did look for one > when writing the original patch but couldn't find it. It's possible I > was hungover from the Jagermeister the night before though (EDB party > at pgCon :-) ). > hehe  >> Comments? > > You spelt colour wrong :-). Other than that (and the possible issue > above), looks good. > Yeah, my first (unsent) mail used color. I changed all color with colour because of the spelling in pgAdmin -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
06-17-2008, 04:04 AM
| |||
| |||
| Re: A fix and a new functionnality for the colourpatch Dave Page a écrit : > On Sat, Jun 14, 2008 at 4:21 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: > [...] >> Comments? > > You spelt colour wrong :-). Other than that (and the possible issue > above), looks good. > Can I commit this patch? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
|
06-17-2008, 04:04 AM
| ||||
| ||||
| Re: A fix and a new functionnality for the colour patch On Mon, Jun 16, 2008 at 9:03 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Dave Page a écrit : >> >> On Sat, Jun 14, 2008 at 4:21 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >> [...] >>> >>> Comments? >> >> You spelt colour wrong :-). Other than that (and the possible issue >> above), looks good. >> > > Can I commit this patch? Sure. As a general rule if there are no objections within a couple of days I say go for it. You're experienced in the code now, and we can always fix any problems that may arise. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers |
Linear Mode
