Tom Lane wrote:
> It occurs to me that maybe we should just add src/pl to the toplevel
> installcheck target, which would make the whole thing pretty
> automatic. However, contrib isn't in that target, so maybe the PLs
> shouldn't be either. Thoughts?

Contrib isn't built by default, so it isn't tested by default. But the
PLs that are built should also be tested, I think.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

Peter Eisentraut wrote:

>Tom Lane wrote:
>
>
>>It occurs to me that maybe we should just add src/pl to the toplevel
>>installcheck target, which would make the whole thing pretty
>>automatic. However, contrib isn't in that target, so maybe the PLs
>>shouldn't be either. Thoughts?
>>
>>
>
>Contrib isn't built by default, so it isn't tested by default. But the
>PLs that are built should also be tested, I think.
>
>
>

I agree. That will also mean that buildfarm members will automatically
start doing the checks (as long as they are set up to build the PLs), so
it would be an extra bonus for me :-)

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@postgresql.org so that your
message can get through to the mailing list cleanly

Andrew Dunstan <andrew@dunslane.net> writes:
> I agree. That will also mean that buildfarm members will automatically
> start doing the checks (as long as they are set up to build the PLs), so
> it would be an extra bonus for me :-)

The only argument I can think of against it is that the buildfarm
status page will then not distinguish core system check failures
from PL check failures. If that doesn't bother you, we can make
it so.

regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>I agree. That will also mean that buildfarm members will automatically
>>start doing the checks (as long as they are set up to build the PLs), so
>>it would be an extra bonus for me :-)
>>
>>
>
>The only argument I can think of against it is that the buildfarm
>status page will then not distinguish core system check failures
>from PL check failures. If that doesn't bother you, we can make
>it so.
>
>
>
>

That's probably a good point. I was just being a little too lazy.
Building an extra check step in is not very difficult - it will just
take a little while for all the buildfarm emebers to catch up. But since
we're still 6 weeks even from feature freeze that shouldn't matter too
much. I'll get onto it.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 9: the planner will ignore your desire to choose an index scan if your
joining column's datatypes do not match