Unix Technical Forum

Re: Proposed patch for sequence-renaming problems

This is a discussion on Re: Proposed patch for sequence-renaming problems within the Pgsql Patches forums, part of the PostgreSQL category; --> Tom Lane wrote: > Here's an updated version of the patch. There's now just one nextval() > function, taking ...


Go Back   Unix Technical Forum > Database Server Software > PostgreSQL > Pgsql Patches

FAQ Members List Calendar Search Today's Posts Mark Forums Read
  #1 (permalink)  
Old 04-18-2008, 12:56 AM
Michael Paesold
 
Posts: n/a
Default Re: Proposed patch for sequence-renaming problems

Tom Lane wrote:
> Here's an updated version of the patch. There's now just one nextval()
> function, taking regclass, and backwards compatibility is handled
> through an implicit text-to-regclass cast. Existing dumps will not see
> any behavioral changes because nextval('foo') will be dumped as
> nextval('foo'::text), but new entries of "nextval('foo')" will be
> captured as regclass constants instead.
>
> I noted that this version caused a couple more regression tests to fail;
> for instance, the constraints test was expecting that it could drop and
> recreate a sequence that was referenced by a default expression spelled
> as "nextval('foo')". So we are paying for improved ease of use by
> taking a larger backwards-compatibility risk than the original patch
> did.
>
> Last call for objections ...


No objection, but +1 from me. If this is the best solution people can
agree on, better now than later. The missing dependencies for sequences
were a bug in the first place, IMHO.

Best Regards,
Michael Paesold

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

http://www.postgresql.org/docs/faq

Digg this Post!Add Post to del.icio.usBookmark Post in TechnoratiFurl this Post!
Reply With Quote
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are On
Forum Jump


All times are GMT. The time now is 07:25 PM.


Powered by vBulletin® Version 3.6.5
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Search Engine Optimization by vBSEO 3.2.0
www.UnixAdminTalk.com